Fix Android release that generates a .aab file #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating Android release generates a .aab file. The Build() function was working with *.apk files only. So the AAB file was not copied and triggered a SELinux error. The copy sh command failed also. This commit fixes the problem by changing the pattern to match on copy, and the package name using ".aab" suffix. NOTE: it could be better to use filepath.Glob() to find files and use os.Rename() instead.
andydotxyz
approved these changes
Sep 2, 2023
|
The failing tests indicate we'll need to update the tested versions to match Fyne... |
|
Yes, this require an image release with latest Fyne. |
|
Do you mind synchronizing this with latest fyne-cross develop? I think it should be good to merge after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Creating Android release generates a .aab file. The Build() function was working with *.apk files only. So the AAB file was not copied and triggered a SELinux error. The copy sh command also failed.
This commit fixes the problem by changing the pattern to match on copy, and the package name using ".aab" suffix.
NOTE: it could be better to use filepath.Glob() to find files and use os.Rename() instead.
Checklist: